Skip to content

grep: retire GREP_OPTIONS #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandfoy merged 1 commit into from
Jan 3, 2025
Merged

grep: retire GREP_OPTIONS #897

briandfoy merged 1 commit into from
Jan 3, 2025
+1 −9

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2025

  • I discovered that GNU grep 3.6 on my Linux system completely ignores GREP_OPTIONS
  • I did a little reading and the feature had been removed from GNU grep (probably for security reasons)
  • Original BSD grep and current OpenBSD grep don't have GREP_OPTIONS, so remove it (it's not a standard thing anyway)

@mknos
grep: retire GREP_OPTIONS
6946a33 
* I discovered that GNU grep 3.6 on my Linux system completely ignores GREP_OPTIONS
* I did a little reading and the feature had been removed from GNU grep (probably for security reasons)
* Original BSD grep, and current OpenBSD grep doesn't have GREP_OPTIONS, so remove it (it's not a standard thing anyway)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Jan 3, 2025
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 01:02 — with GitHub Actions Inactive
@briandfoy briandfoy self-assigned this Jan 3, 2025
@briandfoy briandfoy merged commit 9555402 into briandfoy:master Jan 3, 2025
21 of 22 checks passed
@briandfoy
Copy link
Owner

briandfoy commented Jan 3, 2025

changes: remove GREP_OPTIONS environment variable, which GNU grep removed (security)

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2025
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:11 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:12 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12591036448

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12578193049: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:14 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:15 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:15 — with GitHub Actions Inactive
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @briandfoy @coveralls