Skip to content

expand: garbage collect a global #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandfoy merged 1 commit into from
Jan 3, 2025
Merged

expand: garbage collect a global #900

briandfoy merged 1 commit into from
Jan 3, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2025

  • ARGV is a list of files, which could be empty if stdin default is used
  • Using a direct copy of ARGV provides no benefit
  • The usage() function was previously converted to not take any params

@mknos
expand: garbage collect a global
13eec96 
* ARGV is a list of files, which could be empty if stdin default is used
* Using a direct copy of ARGV provides no benefit
* The usage() function was previously converted to not take any params
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: expand The expand program labels Jan 3, 2025
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing January 3, 2025 03:32 — with GitHub Actions Failure
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:35 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:35 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12592330121

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12591947952: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 03:37 — with GitHub Actions Inactive
@briandfoy briandfoy self-assigned this Jan 3, 2025
@briandfoy briandfoy merged commit d2196f9 into briandfoy:master Jan 3, 2025
21 of 23 checks passed
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jan 3, 2025
@briandfoy briandfoy removed the Priority: low get to this whenever label Jan 3, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: expand The expand program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy