Skip to content

ed: e! should not set filename #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandfoy merged 1 commit into from
Jan 17, 2025
Merged

ed: e! should not set filename #919

briandfoy merged 1 commit into from
Jan 17, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Jan 17, 2025

  • I hadn't tested this scenario before
  • First I start ed with a file a.c
  • The command "e !ifconfig" then replaces the buffer with the output of ifconfig
  • Listing current filename with "f" command after this should still show "a.c" (this is how GNU and OpenBSD versions behave)
  • The directory check should not happen for "e !..." case

@mknos
ed: e! should not set filename
b273c27 
* I hadn't tested this scenario before
* First I start ed with a file a.c
* The command "e !ifconfig" then replaces the buffer with the output of ifconfig
* Listing current filename with "f" command after this should still show "a.c" (this is how GNU and OpenBSD versions behave)
* The directory check should not happen for "e !..." case
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 17, 2025
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:00 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 17, 2025 02:01 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12821203117

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.389%
Totals Coverage Status
Change from base Build 12683001290: -0.7%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

briandfoy
briandfoy reviewed Jan 17, 2025
View reviewed changes
@briandfoy briandfoy self-assigned this Jan 17, 2025
@briandfoy briandfoy added Type: bug an existing feature does not work Status: changes requested adjust the pull request as noted in comments and removed Type: enhancement improve a feature that already exists labels Jan 17, 2025
@briandfoy briandfoy merged commit c35ac25 into briandfoy:master Jan 17, 2025
21 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever Status: changes requested adjust the pull request as noted in comments labels Jan 17, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy left review comments

Assignees

@briandfoy briandfoy

Labels

Program: ed The ed program Status: released there is a new release with this fix Type: bug an existing feature does not work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy