Skip to content

patch: improve validation of ed diffs #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

patch: improve validation of ed diffs #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion bin/patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,14 @@ sub apply {
shift(@hunk) =~ m!^(\d+)(?:,(\d+))?([acds])!
or $self->throw('Unable to parse ed script');

my ($start, $end, $cmd) = ($1, $2 || $1, $3);
my ($start, $end, $cmd) = ($1, $2, $3);
$end = $start unless defined $end; # 0 can appear
if ($start > $end) {
$self->throw("Invalid address range: $start,$end\n");
}
if ($start == 0 && $cmd ne 'a') {
$self->throw("Address zero invalid for command: $start,$end$cmd\n");
}

# We don't parse substitution commands and assume they all mean
# s/\.\././ even if they really mean s/\s+// or such. And we
Expand Down
Loading