Add test for 'yes' #992
Merged
Add test for 'yes' #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs yes as child process with parent reading ten lines. May be run on alternative yes programs for comparison.
ludovic-tc
temporarily deployed
to
housekeeping
GitHub Actions
Inactive
github-actions
bot
added
Priority: low
Contributor
Author
|
Hmm – looks like the Appveyor ubuntu2004 build failed! That's a surprise ... I'm guessing the child process got blocked somehow. I specifically wrote it to perform a unidirectional read so I didn't expect that to be a problem. |
briandfoy
requested changes
Nov 3, 2025
Owner
briandfoy
left a comment
briandfoy
left a comment
There was a problem hiding this comment.
The test looks good, but I think you have an extra file in this commit. Did you mean to include t/yes/yes?
t/yes/yes
Outdated
| @@ -0,0 +1,47 @@ | |||
| #!/usr/bin/env perl | |||
Owner
There was a problem hiding this comment.
Did you mean to commit this file?
Contributor
Author
There was a problem hiding this comment.
Hello brian, many thanks. I certainly did not! What a howler. Fix imminent.
briandfoy
added
Status: changes requested
Owner
|
I'll give you about a week to respond, and failing that I'll fix up the pull request and merge it. |
briandfoy
approved these changes
Nov 7, 2025
briandfoy
temporarily deployed
to
housekeeping
GitHub Actions
Inactive
github-actions
bot
added
Status: accepted
briandfoy
added
Type: testing
Owner
|
This will be part of the next release, which might be a bit. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the
/bin/yesscript.I hope this may be considered useful even though 'yes' is a very simple program. My intention was partly to complete an easy task with a view to hopefully making more substantial contributions in future.
I have attempted to write it cogently and adapt it to the house style, but suspect I have come up short on both counts.
I could not find a standing dev branch so have targeted master, but can easily target a different branch if desired.
Should this humble contribution is of interest to the project, I would be honoured to receive any and all feedback, whether detailed or e.g. just 'go back and look at these guidelines again' or 'run perltidy with this config'.
In particular, I will quite understand if you would prefer this rebased into a single commit.
I have run it with
provefrom my forked repo's root, and it seemed to play well with the other tests, but do let me know if I have missed some complete howlers.Best wishes and thanks.