Skip to content

primes: prompt for START and END in interactive mode #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

primes: prompt for START and END in interactive mode #993

merged 1 commit into from
Nov 4, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Nov 4, 2025

  • Previously there was no way to specify the END value when starting primes with no arguments.
  • Previously there was no prompt given to indicate that the user needs to type a value for START (user might wait for primes to calculate but in fact nothing is happening).
  • To me it makes more sense to show a prompt for both START and END
  • Clarify POD slightly

@mknos
primes: prompt for START and END in interactive mode
44f2be4 
* Previously there was no way to specify the END value when starting primes with no arguments.
* Previously there was no prompt given to indicate that the user needs to type a value for START
* To me it makes more sense to show a prompt for both START and END
* Clarify POD slightly
@mknos mknos temporarily deployed to automated_testing November 4, 2025 10:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2025 10:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2025 10:21 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing November 4, 2025 10:21 — with GitHub Actions Failure
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: primes The primes program Status: needs verification issue needs to be verified Type: bug an existing feature does not work labels Nov 4, 2025
@coveralls
Copy link

coveralls commented Nov 4, 2025

Pull Request Test Coverage Report for Build 19065425190

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 61.202%
Totals Coverage Status
Change from base Build 18976527666: -1.8%
Covered Lines: 1863
Relevant Lines: 3044
💛 - Coveralls

@briandfoy briandfoy merged commit ba6fcf9 into briandfoy:master Nov 4, 2025
6 of 12 checks passed
@github-actions github-actions bot removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Nov 4, 2025
@briandfoy briandfoy removed the Type: bug an existing feature does not work label Nov 4, 2025
@github-actions github-actions bot added the Status: accepted The fix is accepted label Nov 4, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 4, 2025
@briandfoy
Copy link
Owner

briandfoy commented Nov 4, 2025

Released in 1.053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: primes The primes program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy