Skip to content

du: correct logic for -s option #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

du: correct logic for -s option #996

merged 1 commit into from
Dec 2, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Dec 2, 2025

  • The function traverse() takes a directory name param and first does stat() or lstat() depending on other command options
  • If stat() fails an error is printed, final exit code is set to 1 and the function returns early to avoid printing a total
  • The same error logic should happen for later opendir() failure, otherwise an unhelpful total will be printed after the error message if the -s option is used
  • I verified this by forcing opendir to fail

@mknos
du: logic correction for -s option
11fde63 
* The function traverse() takes a directory name param and first does stat() or lstat() depending on other command options
* If stat() fails, error is printed, final exit code is set to 1 and the function returns early to avoid printing a total
* The same error logic should happen for later opendir() failure, otherwise an unhelpful total will be printed after the error message if the -s option is used
* I verified this by forcing opendir to fail
@mknos mknos had a problem deploying to automated_testing December 2, 2025 11:41 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing December 2, 2025 11:41 — with GitHub Actions Failure
@mknos mknos temporarily deployed to automated_testing December 2, 2025 11:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 2, 2025 11:41 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: du The du program Status: needs verification issue needs to be verified Type: bug an existing feature does not work labels Dec 2, 2025
@briandfoy briandfoy merged commit 8c90873 into briandfoy:master Dec 2, 2025
4 of 12 checks passed
@github-actions github-actions bot added Status: accepted The fix is accepted and removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Dec 2, 2025
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: du The du program Status: accepted The fix is accepted Type: bug an existing feature does not work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mknos @briandfoy