[fix]: make page.evaluate() use main world
#1308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 492f0a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
seanmcguire12
changed the title
context.addInitScript() use correct isolated worldcontext.addInitScript() use main world
seanmcguire12
changed the title
context.addInitScript() use main worldpage.evaluate() use main world
Member
Author
|
@greptielai |
Member
Author
|
@cubic-dev-ai review this PR |
@seanmcguire12 I've started the AI code review. It'll take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/core/lib/v3/tests/context-addInitScript.spec.ts">
<violation number="1" location="packages/core/lib/v3/tests/context-addInitScript.spec.ts:127">
P2: Use a local `data:` URL (or other deterministic fixture) instead of hitting `https://example.com` so the test remains reliable offline.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
seanmcguire12
deleted the
seanmcguire/stg-1012-make-contextaddinitscript-add-to-correct-js-world
branch
seanmcguire12
restored the
seanmcguire/stg-1012-make-contextaddinitscript-add-to-correct-js-world
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
page.evaluate()uses thev3-worldaddInitScript()what changed
page.evaluate()uses the main worldtest plan
page.evaluate()on a script added viacontext.addInitScript()