Skip to content

Conversation

@denar90
Copy link

@denar90 denar90 commented Mar 18, 2016

Hi. I'm using rigger in my Atom package. I'm getting error like Refused to evaluate a string as JavaScript because 'unsafe-eval'.... when rigger uses _.template() method to build template.
Here solution which I found and implemented in this pr.

@DamonOehlman
Copy link
Member

@denar90 thanks for the PR. I might even take a look at removing underscore templates all together as I'm really just doing a fairly simple string replacement, that could probably be handled by something much simpler.

Are you able to build your atom package using your modified version? You should be able to reference your github package as a dev dependency until we get a resolution.

@denar90
Copy link
Author

denar90 commented Mar 22, 2016

Yes, I'll do it this. Should I close this PR?

@DamonOehlman
Copy link
Member

I'd say leave it open until I get the alternative implementation done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants