fix(p2-shim): missing browser shim bits #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue that was exposed when all imports are checked for existence during import. The browser shims at present not only are incomplete, but they're also missing key functions and classes that should be present. This commit unfortunately doesn't actually bring the browser implementation up to snuff -- rather we simply add the placeholders that should be there (and will fail if use is attempted at runtime). Up until now imports were not checked for existence, but the usefulness of explicit upfront errors (instead of less scruable ones later) is a good tradeoff. In the future an option to disable import checks may be added.
vados-cosmonic
force-pushed
the
fix(p2-shim)=missing-browser-shim-bits
branch
from
f3e3db5 to
c1e0b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue that was exposed when all imports are checked for existence during import. The browser shims at present not only are incomplete, but they're also missing key functions and classes that should be present.
This commit unfortunately doesn't actually bring the browser implementation up to snuff -- rather we simply add the placeholders that should be there (and will fail if use is attempted at runtime).
Up until now imports were not checked for existence, but the usefulness of explicit upfront errors (instead of less scruable ones later) is a good tradeoff.
In the future an option to disable import checks may be added.