-
Notifications
You must be signed in to change notification settings - Fork 88
Experimental building of npm packages #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One thing I like to do is to have a script in the package.json that performs local (as in project-local) tasks. In this case compiling code. Then there is a workspace scoped task runner, currently xtask that calls those project-local tasks in the right order. I would prefer Just to be the workspace task runner, there is already a Justfile in there! I like Just over xtask as i feel Justfiles are quite readable so it becomes more clear what exactly the thing is doing. But I am also fine with xtask ofcourse. |
|
I build only the src folder at the moment, and I put the output in the \o/ |
|
Hey @elmerbulthuis thanks for getting this PR out there! Would you mind breaking the work for only one project (jco-transpile) off into another PR? You can leave this one open and "just" cherry pick changes over. I'd like to review that small piece and then split off some more projects and make progress one chunk at a time if possible! With regards to the
I think all three of these have their place -- IMO the things they do arguably should all be accessible from To your concern specifically:
Just is at a higher level of abstraction than
This sounds great to me, |
see #717
This demonstrates what it would look like if we would introduce a build step. This PR also removes .d.ts files from the repo and generated them in a seperate folder (dist) during build.