Skip to content

WIP: create 4-byte struct ValTypePacked to offset larger enum ValType #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: create 4-byte struct ValTypePacked to offset larger enum ValType #2369

wants to merge 1 commit into from

Conversation

@fitzgen
Copy link
Member

@fitzgen fitzgen commented Nov 7, 2025

No description provided.

@fitzgen fitzgen mentioned this pull request Nov 7, 2025
Merged
4 tasks
@fitzgen
Copy link
Member Author

fitzgen commented Nov 7, 2025

What still needs to be done is to integrate with MaybeValType and the validator

@alexcrichton
Copy link
Member

alexcrichton commented Nov 7, 2025

Some more discussion here, but for now the conclusion is that it's best to leave ValType as-is and avoid *Packed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fitzgen @alexcrichton