fix(wit-parser): validate case insensitivity #2385
Merged
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricochet
force-pushed
the
fix/validate-case-insentive
branch
from
8812bbe to
c60eda9
Compare
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! I think this'll need to happen at the crates/wit-parser/src/resolve.rs layer, however, rather than during the "AST resolve" step. For example include could cause a conflict, and that can't be resolved until src/resolve.rs where at ast/resolve.rs it's perserved as just include without knowing what it points to.
I think that moving it over there might lose some span information, but that's ok. In general it should be pretty easy to move I'd hope, but if you run into trouble let me know. As another minor comment though could the validation of imports/exports be extracted to a helper to avoid duplicating the logic/error message too?
Signed-off-by: Bailey Hayes <[email protected]>
ricochet
force-pushed
the
fix/validate-case-insentive
branch
from
c60eda9 to
88c56d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to catch invalid WIT like the one is this report early: bytecodealliance/wit-bindgen#1411