feat: add ResettableTimer for simplified timer management #1467
+499
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marpond
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht,
shijiesheng and
taylanisikdemir
as code owners
jakobht
reviewed
Nov 3, 2025
Member
jakobht
left a comment
jakobht
left a comment
There was a problem hiding this comment.
Looks good. Added a few suggestions.
I think lets put this in the x/resettabletimer package since it's on top of the basic client
Marpond
force-pushed
the
master
branch
2 times, most recently
from
8750ebf to
3b6e271
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Marpond
force-pushed
the
master
branch
3 times, most recently
from
0706785 to
8648fd4
Compare
jakobht
approved these changes
Nov 24, 2025
| #### Example: Inactivity Timeout with Dynamic Duration | ||
|
|
||
| ```go | ||
| func InactivityTimeoutWorkflow(ctx workflow.Context) error { |
Signed-off-by: Marpond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduces an abstraction of resetting timers via
ResettableTimerinx/resettabletimer.Why?
Simplifies common timer patterns where timers need to be updated or extended. Previously, we had to manually cancel the existing timer context, handle
CanceledError, and create a new timer. WithResettableTimer, a singleReset()call handles this automatically.How did you test it?
Added workflow unit tests to ensure functional correctness and deterministic replay behavior.
Potential risks
Low risk. Does not alter current timer behavior, only adds a user-friendly interface built on existing timer primitives.