GH2101: Disable report printing if verbosity of logger is Quiet #4148
Conversation
|
@microsoft-github-policy-service agree |
augustoproiete
changed the title
gep13
force-pushed
the
feature/no-output-on-log-quiet
branch
from
55b4d7d to
1ea2f39
Compare
|
@deniszykov rather than create a new PR, I have taken the liberty to update this PR using the suggested approach discussed in the original issue. Please let me know if you have any concerns about me doing this. |
I don't mind, and thanks. I was actually thinking of adding another logging level below Quiet. But I solved my problem differently and forgot about this PR. |
gep13
force-pushed
the
feature/no-output-on-log-quiet
branch
from
1ea2f39 to
162e5c9
Compare
|
@deniszykov said... Perfect! I have started a process of reviewing some of the older PR's that we have, and I stumbled across your one. |
gep13
changed the title
As part of a normal Cake execution, a report summary is always shown at the end. This includes information about what tasks were ran, how long they took, etc. However, there are those that don't want to allow this to happen. This commit introduces a new configuration option, which allows the report summary to not be shown. This can be done in the usual way with a command line parameter, cake.config file entry, or an environment variable.
gep13
force-pushed
the
feature/no-output-on-log-quiet
branch
from
162e5c9 to
ca440e5
Compare
| var report = await Engine.RunTargetAsync(_context, _executionStrategy, Settings).ConfigureAwait(false); | ||
|
|
||
| if (report != null && !report.IsEmpty) | ||
| var noReportEnabled = _configuration.GetValue("Settings_NoReport") ?? bool.FalseString; |
There was a problem hiding this comment.
@devlead I tried to use the Constants class here, rather than the hard coded Settings_NoReport, but it is marked internal. Should I create a new Constants class in the Cake.Cli project?
3 participants
fix for #2101