Skip to content

Conversation

@cubic-dev-ai
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot commented Nov 17, 2025

🤖 PR by cubic

This PR addresses the comment in #25175 – fix: put booking details and calendar behind feature flag

File: apps/web/app/(use-page-wrapper)/(main-nav)/bookings/[status]/ViewToggleButton.tsx
Line: 26
Comment:

For desktop users arriving with view=calendar, this effect immediately forces the query state back to list. During SSR the media query hook falls back to false, so on the first client effect isMobile is still true and setView("list") runs before the hook corrects the match result, wiping out the intended calendar view. Guard the mobile override so it only triggers once the media query has definitively reported a mobile viewport.

This fix was automatically generated. Please review the changes carefully before merging.

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Nov 17, 2025 2:53pm
cal-eu Ignored Ignored Nov 17, 2025 2:53pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


cubic Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Delay mobile override until media query confirms mobile viewport (merges into #25175)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Base automatically changed from fix/put-booking-redesign-feature-flagged to main November 19, 2025 15:27
@eunjae-lee eunjae-lee requested review from a team as code owners November 19, 2025 15:27
@cubic-dev-ai cubic-dev-ai bot closed this Nov 19, 2025
@cubic-dev-ai
Copy link
Contributor Author

cubic-dev-ai bot commented Nov 19, 2025

This fix PR has been automatically closed because the parent PR #25175 was closed.

If you still need this fix, please reopen the parent PR first, or create a new PR with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants