-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: paid seated event attendee privacy #25258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: paid seated event attendee privacy #25258
Conversation
|
@dhairyashiil is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 6 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/web/modules/bookings/views/bookings-single-view.tsx">
<violation number="1" location="apps/web/modules/bookings/views/bookings-single-view.tsx:169">
The Stripe polling loop always reloads the page every 2s until payment succeeds, so a failed/slow payment traps the user in an infinite reload loop.</violation>
<violation number="2" location="apps/web/modules/bookings/views/bookings-single-view.tsx:429">
Wrap the new "Processing payment" headline in t() so it participates in localization.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
anikdhabal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to fix this issue, let's follow these steps:
- Store the paymentId in the bookingSeat table.
- After a successful payment, query the seat using the passed paymentId to find the attendee/seat, and then send them an email
What does this PR do?
Visual Demo
Tested for both scenarios
Screen.Recording.2025-11-19.at.3.07.46.PM.mov
Summary by cubic
Fixes attendee privacy for paid seated events by sending seat-specific notifications after payment and honoring seatsShowAttendees. Addresses #25256 and CAL-6782 to prevent exposing other attendees’ details to each buyer.
Written for commit 9f451e5. Summary will update automatically on new commits.