Skip to content

Conversation

@m4olivei
Copy link
Contributor

Description

Un-skip the tests marked as such for the carousel e2e test.

Changelog

Changed

  • Fixed carousel e2e Storybook tests

@m4olivei m4olivei requested a review from a team as a code owner November 25, 2024 20:07
@m4olivei m4olivei requested review from Valentin-Sorin-Nicolae, andy-blum, bruno-amorim and marcelojcs and removed request for a team November 25, 2024 20:07
@netlify
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 22a757c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/67696ad67b8d8400080430d6
😎 Deploy Preview https://deploy-preview-12120--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 22a757c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/67696ad6aca64000087b312f
😎 Deploy Preview https://deploy-preview-12120--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Valentin-Sorin-Nicolae
Copy link
Contributor

Hi Matt, I see 2 of them still failing and a percy one.

@m4olivei
Copy link
Contributor Author

Hi Matt, I see 2 of them still failing and a percy one.

Thanks! I was seeing some unreliable results locally as well, depending on the browser, wrt checking the inert attribute on the carousel cards. I've removed those checks. Lets see if that helps.

Percy fail is odd, b/c I didn't change the component at all 🤔

@andy-blum
Copy link
Contributor

Percy differences appear to be additional elements in the carousel?

Screenshot 2024-11-26 at 2 37 21 PM Screenshot 2024-11-26 at 2 37 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants