chore(chat): Ai components doc updates #600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornec
requested review from
devadula-nandan,
kennylam,
makafsal and
tay1orjones
and removed request for
a team
❌ Deploy Preview for carbon-labs-web-components failed. Why did it fail? →
|
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
annawen1
reviewed
May 19, 2025
| # Other packages | ||
| /packages/react/src/components/AnimatedHeader/ @carbon-design-system/animated-header-devs | ||
| /packages/react/src/components/Processing/ @carbon-design-system/processing-devs | ||
| <<<<<<< Updated upstream |
annawen1
reviewed
May 19, 2025
jlongshore
requested changes
Jun 3, 2025
Contributor
jlongshore
left a comment
jlongshore
left a comment
There was a problem hiding this comment.
Just a few small things
| (example) => | ||
| html` | ||
| <h3>${example.title}</h3> | ||
| <br /> |
Contributor
There was a problem hiding this comment.
Prefer styles to add spacing rather than break tags
| this.scrollDiv = this; /*this.shadowRoot?.querySelector( | ||
| '.clabs--chat-messages-container' | ||
| ); | ||
| );*/ |
| scrollTarget = this._previousScrollHeight; | ||
| } | ||
| console.log(this.scrollDiv); | ||
| this.scrollDiv?.scrollTo({ |
Contributor
There was a problem hiding this comment.
Assuming these console log's should be removed as well
| : ''} | ||
| ${dockingEnabled ? clabsPrefix + '--chat-messages-container-docked' : ''}"> | ||
| : ''} ${dockingEnabled |
Contributor
There was a problem hiding this comment.
This is a little hard to follow with all the nested ternary's here - is there a better place I'm wondering... maybe before the return you could have an array and for each of those evaluated class names, if supported ( streamResponses, dockingEnabled... etc - is truthy ) push the class name... then your class assignment here you could just Array.split(" ").
| */ | ||
| _buildOptions() { | ||
| const whiteTheme = { | ||
| /*const whiteTheme = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}