-
Notifications
You must be signed in to change notification settings - Fork 45
fix(ui-shell): resolve html structure bugs #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(ui-shell): resolve html structure bugs #847
Conversation
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@emyarod I'm seeing this html now, which is still invalid, wasn't sure exactly what part of this needed an upstream change?
|
|
@alisonjoseph I thought that IconButton would need the |
|
@emyarod yes, but it would only need to be a span I think when its part of the pinned rail, otherwise it needs to be an li because it won't be wrapped in the popover. Will need to check any aria roles on that also. |
3e13988 to
6a8cded
Compare




Related #827
This PR updates the sidenav popovers to render inside
lielements as well as removes inline stules inSideNavFlyoutMenunote: the referenced issue will require an upstream update for iconbuttons/tooltips
Changelog
New
Changed
Removed
Testing / Reviewing
confirm that the sidenav popovers and tooltips are rendered properly and check that the styles for the flyout menus are unchanged