Skip to content

Conversation

@emyarod
Copy link
Member

@emyarod emyarod commented Oct 14, 2025

Related #827

This PR updates the sidenav popovers to render inside li elements as well as removes inline stules in SideNavFlyoutMenu

note: the referenced issue will require an upstream update for iconbuttons/tooltips

Changelog

New

  • side nav flyout menu classes for display styles

Changed

  • rendered sidenav popover and tooltip html

Removed

  • inline styles

Testing / Reviewing

confirm that the sidenav popovers and tooltips are rendered properly and check that the styles for the flyout menus are unchanged

@emyarod emyarod requested a review from a team as a code owner October 14, 2025 14:23
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit 6a8cded
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-web-components/deploys/68f7ce0afed3150008102104
😎 Deploy Preview https://deploy-preview-847--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit 6a8cded
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-react/deploys/68f7ce0a1fa70e000859be37
😎 Deploy Preview https://deploy-preview-847--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@alisonjoseph alisonjoseph requested a review from a team as a code owner October 14, 2025 20:28
@alisonjoseph
Copy link
Member

alisonjoseph commented Oct 15, 2025

@emyarod I'm seeing this html now, which is still invalid, wasn't sure exactly what part of this needed an upstream change?

<li class=popover...>
   <li class=side-nav__item....>
Screenshot 2025-10-15 at 8 55 49 AM

@emyarod
Copy link
Member Author

emyarod commented Oct 15, 2025

@alisonjoseph I thought that IconButton would need the as prop to pass into the underlying Tooltip for some of the sidenav items. I'll also look into the doubled li > li, but it should be fine if we're able to change the innermost li to a span or something right?

@alisonjoseph
Copy link
Member

@emyarod yes, but it would only need to be a span I think when its part of the pinned rail, otherwise it needs to be an li because it won't be wrapped in the popover. Will need to check any aria roles on that also.

@emyarod emyarod force-pushed the 827-fix/uishell-html-structure branch from 3e13988 to 6a8cded Compare October 21, 2025 18:16
@alisonjoseph
Copy link
Member

alisonjoseph commented Oct 22, 2025

Getting closer, but html still isn't quite right. spans can't be direct children of a ul
Screenshot 2025-10-22 at 3 33 18 PM

and looks like the updates broke styling in the other views
Screenshot 2025-10-22 at 3 34 38 PM

Screenshot 2025-10-22 at 3 35 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants