-
Notifications
You must be signed in to change notification settings - Fork 45
feat(uishell): update HeaderPopover styles #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(uishell): update HeaderPopover styles #890
Conversation
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ariellalgilmore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just need to resolve conflicts
This comment was marked as resolved.
This comment was marked as resolved.
|
@thyhmdo what browser are you in? It looks correct in Firefox and Chrome to me. |
|
@alisonjoseph oh I was on Arc. Ok Arc always has issues then |
emyarod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
|
@thyhmdo the Global Header is being contributed by a different team. https://deploy-preview-890--carbon-labs-react.netlify.app/?path=/story/components-uishell--demo |






Closes #817
Updates to
HeaderPopoverandMenuButtonwith new background token, border and drop shadow as default.There is an additional open issue to adjust the trigger button for the HeaderPopover/Profile #871
We may need a separate issue to look at Tooltips inside the Header? @carbon-design-system/design
Changelog
Changed
HeaderPopoverandMenuButtonto have thebackgroundToken, background,dropShadow, true andbordertrue.Removed
Testing / Reviewing
Check that HeaderPopovers and MenuButtons in UIShell Demo story match spec in issue