Skip to content

Conversation

@alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 23, 2025

Closes #817

Updates to HeaderPopover and MenuButton with new background token, border and drop shadow as default.

There is an additional open issue to adjust the trigger button for the HeaderPopover/Profile #871

We may need a separate issue to look at Tooltips inside the Header? @carbon-design-system/design

Changelog

Changed

  • update styles to come from @carbon/react instead of @carbon/styles
  • update to latest version of @carbon/react and @carbon/styles
  • Update HeaderPopover and MenuButton to have the backgroundToken, background, dropShadow, true and border true.

Removed

  • style overrides for Profile component
  • label from ContainedList
  • style overrides for ContainedList to hide label

Testing / Reviewing

Check that HeaderPopovers and MenuButtons in UIShell Demo story match spec in issue

@alisonjoseph alisonjoseph requested review from a team as code owners October 23, 2025 20:00
@alisonjoseph alisonjoseph requested review from ariellalgilmore, emyarod and thyhmdo and removed request for a team October 23, 2025 20:00
@netlify
Copy link

netlify bot commented Oct 23, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit dc177cc
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-web-components/deploys/690cae5efebddc0008c7343c
😎 Deploy Preview https://deploy-preview-890--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 23, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit dc177cc
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-react/deploys/690cae5e5521e10008d1c723
😎 Deploy Preview https://deploy-preview-890--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@alisonjoseph alisonjoseph marked this pull request as draft October 23, 2025 20:12
@alisonjoseph alisonjoseph marked this pull request as ready for review October 23, 2025 20:39
@alisonjoseph alisonjoseph requested a review from a team as a code owner October 23, 2025 20:39
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just need to resolve conflicts

@alisonjoseph

This comment was marked as resolved.

@alisonjoseph alisonjoseph requested a review from a team as a code owner October 30, 2025 19:42
@alisonjoseph alisonjoseph self-assigned this Nov 5, 2025
@github-project-automation github-project-automation bot moved this to 🚦 In Review in Design System Nov 5, 2025
@alisonjoseph alisonjoseph moved this from 🚦 In Review to 🏗 In Progress in Design System Nov 5, 2025
@alisonjoseph alisonjoseph removed their assignment Nov 5, 2025
@alisonjoseph alisonjoseph marked this pull request as ready for review November 6, 2025 14:22
@thyhmdo
Copy link
Member

thyhmdo commented Nov 6, 2025

Web: Unrelated, but the ghost button's color looks incorrect across themes
image
image


React:CommonHeader seems to have a different style?

image

@alisonjoseph
Copy link
Member Author

@thyhmdo what browser are you in? It looks correct in Firefox and Chrome to me.
Screenshot 2025-11-06 at 9 35 53 AM
Screenshot 2025-11-06 at 9 36 04 AM

@thyhmdo
Copy link
Member

thyhmdo commented Nov 6, 2025

@alisonjoseph oh I was on Arc. Ok Arc always has issues then

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@thyhmdo
Copy link
Member

thyhmdo commented Nov 6, 2025

It's a detail, but can we line up the border of the profile with the line of the global header?
image

@alisonjoseph
Copy link
Member Author

@thyhmdo the Global Header is being contributed by a different team.

https://deploy-preview-890--carbon-labs-react.netlify.app/?path=/story/components-uishell--demo
This is the link for the UI Shell / this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Platforms]: Implement updates to header to fix menu/popover components blending in

5 participants