fix: prevent customize column hook from running on column resize #8640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmenendez
requested review from
jlongshore and
szinta
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
=======================================
Coverage 82.01% 82.01%
=======================================
Files 403 403
Lines 18548 18548
Branches 4189 4189
=======================================
Hits 15212 15212
Misses 3336 3336
🚀 New features to boost your workflow:
|
jlongshore
approved these changes
Nov 19, 2025
szinta
approved these changes
Nov 20, 2025
Contributor
szinta
left a comment
szinta
left a comment
There was a problem hiding this comment.
@davidmenendez It seems this PR addresses only scenario 1, where customized columns addon is used with column resizing. For the second issue (Tagset with column resize) do we have a separate ticket for that, or was it overlooked? Just wanted to check.
Contributor
Author
|
@szinta yeah i haven't been able to replicate that locally yet, so i'm going to do that issue separately |
Merged
via the queue into
carbon-design-system:main
with commit Nov 20, 2025
a6af0cb
34 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8094
prevents the
useEffectinside ofCustomizeColumnsTearsheetfrom running when datagrid columns are being resized, which causes the app to crash from re-renders.CustomizeColumnsTearsheetisn't visible when the user is able to drag the column widths and shouldn't be affected by that interaction anyways.