fix(core): System_nanotime incorrectly returns double #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorruptedVor
force-pushed
the
patch-3
branch
from
f464e09 to
287cfb9
Compare
CorruptedVor
changed the title
CorruptedVor
force-pushed
the
patch-3
branch
from
287cfb9 to
4580f72
Compare
CorruptedVor
force-pushed
the
patch-3
branch
2 times, most recently
from
3f30ba7 to
79440f1
Compare
CorruptedVor
force-pushed
the
patch-3
branch
from
79440f1 to
e48403a
Compare
Collaborator
|
Hi, sorry I missed the notifications for your PRs. Will look into them asap! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast to double leads to a potential loss of significant digits.
64-bit long should be enough, overflow in 2262-04-11 from 23:47:16 to 23:47:17
0x7fffffffffffffff - (9223372037 * 1000000000) < 0, 9223372037 corresponds to 2262uint64_t is more appropriate, considering CLOCK_REALTIME is going to be returning timestamps after 1970 (positive), 32-bit long (the case on 32-bit platforms) suffers
(2^32 / 1000000000) < 5, always overflowing in today's agefrom-type and to-type conversions:
only some of them are missing, it's trivial to add all of them
perhaps we should make the carp compiler output the definitions automatically