Skip to content

TA-3598: Remove baseConfiguration from Diff transports #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2025
Merged

TA-3598: Remove baseConfiguration from Diff transports #193

merged 4 commits into from
Mar 7, 2025

Conversation

@Buqeta
Copy link
Contributor

@Buqeta Buqeta commented Mar 5, 2025 •
edited
Loading

Description

This PR does the following:

  • Removes the baseConfiguration and basePackageConfiguration from Diff transports, since they're not needed anymore.
  • Adds fromValue to ConfigurationChangeTransport.
  • Updates the tests accordingly.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

promeris
promeris previously approved these changes Mar 5, 2025
View reviewed changes
@Buqeta Buqeta marked this pull request as ready for review March 6, 2025 08:26
@Buqeta Buqeta requested review from a team and GencBlakqoriP9 as code owners March 6, 2025 08:26
@Buqeta Buqeta marked this pull request as draft March 6, 2025 09:00
@Buqeta Buqeta marked this pull request as ready for review March 6, 2025 09:48
@Buqeta Buqeta merged commit 6ce299c into master Mar 7, 2025
1 check passed
@Buqeta Buqeta deleted the TA-3598-remove-baseConfiguration-from-diff-transports branch March 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jetakasabaqi jetakasabaqi jetakasabaqi approved these changes

@ZgjimHaziri ZgjimHaziri ZgjimHaziri approved these changes

@promeris promeris promeris approved these changes

@ksalihu ksalihu ksalihu approved these changes

@GencBlakqoriP9 GencBlakqoriP9 Awaiting requested review from GencBlakqoriP9

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Buqeta @jetakasabaqi @ZgjimHaziri @promeris @ksalihu