This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Allow user to set start options per HTTP request #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
changed the title
Contributor
Author
|
Also created census-instrumentation/opencensus-specs#182. |
semistrict
approved these changes
Sep 22, 2018
| // | ||
| // StartOptions.SpanKind will always be set to trace.SpanKindClient | ||
| // for spans started by this transport. | ||
| StartOptions trace.StartOptions |
Contributor
There was a problem hiding this comment.
Should we deprecate this?
Contributor
Author
There was a problem hiding this comment.
If we deprecate this GetStartOptions will be a bad choice of naming. GetX only makes sense when X already exists.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869.