Skip to content

Conversation

@mlutfy
Copy link
Member

@mlutfy mlutfy commented Nov 28, 2025

Overview

More improvements related to #34168:

  • Improves the default PCPInfo layout on mobile
  • Removes the "Delete" link from the PCPInfo page, so people can disable their page, but not delete it. Deleting is pretty drastic and adds to clutter.
  • AdminUI Manage PCP pages: adds "goal" and "raised" columns, and removes the start/end date (those start/end dates are for the upstream Contrib or Event pages, so they're very redundant)
  • AdminUI Manage PCP pages: adds a "is-active" filter, and by default shows only active pages (everywhere I have seen PCP used, they do it on a yearly basis, and disable the old pages, so the filter is very useful).

Before

(described above)

After

AdminUI : Manage Personal Campaign Pages:

2025-11-28_11-39

Mobile support, with lots of text, banner image, etc:

pr34175-1.webm

Technical Details

I manually tweaked the IFNULL etc clauses, because SearchKit would add GROUP_CONCAT around all fields, and then it wasn't really working, so I removed the GROUP_CONCAT because it felt not necessary. I tested this on MariaDB 11.8, but I remember sometimes group-concat behaves differently based on different MySQL modes.

@civibot
Copy link

civibot bot commented Nov 28, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@mlutfy
Copy link
Member Author

mlutfy commented Dec 2, 2025

Related RL PR by @vingle #34197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant