Skip to content

Conversation

@ufundo
Copy link
Contributor

@ufundo ufundo commented Dec 1, 2025

Overview

Enable adding "all custom fields"/"all fields" for an entity when building a SearchKit.

This is draft and needs some cleanup but wanted to give you a sense of what I'm trying to do @colemanw

Before

  • add fields one-by-one
  • dont respond to new fields being created
  • ? crash ? when fields are removed

After

  • add "all custom fields" for an entity using a wildcard

Technical Details

A chunk of this is just de-lodashing some functions.

Then it's breaking the assumption that savedSearch.api_params.select corresponds one-to-one to the columns in search admin.

@civibot
Copy link

civibot bot commented Dec 1, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 1, 2025
Comment on lines 413 to 415
if (col.includes('*')) {
console.log(info);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console says info

@ufundo ufundo force-pushed the search-kit-all-custom-fields branch 2 times, most recently from c7275ee to a624d39 Compare December 8, 2025 18:23
@ufundo ufundo force-pushed the search-kit-all-custom-fields branch from a624d39 to 9aa4943 Compare December 8, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants