fix(parser): Fill in defaults on ignored error #5813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This came up in clap-rs#5812 and is especially problematic for derives. Not really a fan of this solution but its the least invasive. I also considered going wild with error recovery or moving towards a solution for clap-rs#1546.
epage
force-pushed
the
ignore
branch
2 times, most recently
from
f53f902 to
479df35
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in #5812 and is especially problematic for derives.
Not really a fan of this solution but its the least invasive.
I also considered going wild with error recovery or moving towards a
solution for #1546.