Skip to content

fix: ensure all params are trimmed [#236] #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slightfoot merged 1 commit into from
Aug 21, 2025
Merged

fix: ensure all params are trimmed [#236] #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/clerk_auth/lib/src/clerk_api/api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,13 @@ class Api with Logging {
.toList(growable: false);
}

dynamic _ensureNotNullOrEmpty(dynamic param) {
if (param case String param) {
return param.trim().orNullIfEmpty;
}
return param;
}

Future<http.Response> _fetch({
required String path,
HttpMethod method = HttpMethod.post,
Expand All @@ -950,9 +957,10 @@ class Api with Logging {
bool withSession = false,
}) async {
final parsedParams = {
for (final entry in (params ?? const {}).entries)
if (entry.value != null) //
entry.key: entry.value,
if (params?.entries case final entries?) //
for (final MapEntry(:key, :value) in entries) //
if (_ensureNotNullOrEmpty(value) case final value?) //
key: value,
...?nullableParams,
};
final queryParams = _queryParams(
Expand Down Expand Up @@ -1021,7 +1029,7 @@ class Api with Logging {
HttpHeaders.contentTypeHeader: method.isGet
? 'application/json'
: 'application/x-www-form-urlencoded',
if (_tokenCache.clientToken.isNotEmpty) //
if (_tokenCache.hasClientToken) //
HttpHeaders.authorizationHeader: _tokenCache.clientToken,
_kClerkAPIVersion: ClerkConstants.clerkApiVersion,
_kXFlutterSDKVersion: ClerkConstants.flutterSdkVersion,
Expand Down