Unnecessary call update user even field not change #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary call updateUser even if the field not changed
shinyford
merged commit d1ce70e
into
clerk:fix/286-hone-update-user
1 of 2 checks passed
shinyford
pushed a commit
that referenced
this pull request
Oct 7, 2025
Unnecessary call updateUser even if the field not changed
shinyford
pushed a commit
that referenced
this pull request
Oct 7, 2025
Unnecessary call updateUser even if the field not changed
shinyford
added a commit
that referenced
this pull request
Oct 7, 2025
shinyford
pushed a commit
that referenced
this pull request
Oct 17, 2025
Unnecessary call updateUser even if the field not changed
shinyford
added a commit
that referenced
this pull request
Oct 17, 2025
shinyford
added a commit
that referenced
this pull request
Oct 17, 2025
shinyford
pushed a commit
that referenced
this pull request
Oct 20, 2025
Unnecessary call updateUser even if the field not changed
shinyford
added a commit
that referenced
this pull request
Oct 20, 2025
shinyford
added a commit
that referenced
this pull request
Oct 20, 2025
# Conflicts: # packages/clerk_auth/test/_responses/clerk_api/sign_in_test/email_and_password/002.json # packages/clerk_auth/test/_responses/clerk_api/user_details/additional_phone_number/002.json # packages/clerk_auth/test/_responses/clerk_api/user_details/additional_phone_number/003.json # packages/clerk_auth/test/_responses/clerk_api/user_details/additional_phone_number/004.json # packages/clerk_auth/test/_responses/clerk_api/user_details/additional_phone_number/005.json # packages/clerk_auth/test/_responses/clerk_api/user_details/new_name/002.json # packages/clerk_auth/test/_responses/clerk_api/user_details/new_name/004.json # packages/clerk_auth/test/_responses/clerk_api/user_details/new_name/005.json # packages/clerk_auth/test/_responses/clerk_api/user_details/new_name/006.json # packages/clerk_auth/test/_responses/clerk_auth/sign_in_test/sign_in_with_email_code/005.json # packages/clerk_auth/test/_responses/clerk_auth/sign_in_test/sign_in_with_password/003.json # packages/clerk_auth/test/_responses/clerk_auth/sign_in_test/sign_in_with_phone_code/005.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_and_password/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_and_password/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_and_password/003.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_link/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/email_link/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/phone_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/phone_code/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_in_test/phone_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/004.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/005.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/email_code/006.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/004.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/005.json # packages/clerk_auth/test/_responses/integration/clerk_api/sign_up_test/phone_code/006.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/002.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/003.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/004.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/005.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_email/006.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_phone_number/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/additional_phone_number/006.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/new_name/001.json # packages/clerk_auth/test/_responses/integration/clerk_api/user_details/new_name/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_code/004.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_link/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_link/004.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_link/005.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_email_link/006.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_password/001.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_phone_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_phone_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_in_test/sign_in_with_phone_code/004.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/001.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/004.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/005.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/006.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/007.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/008.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_and_phone_code/009.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/001.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/003.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/004.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/005.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/006.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/007.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/008.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/009.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/010.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/sign_up_with_email_code_and_typo/011.json # packages/clerk_auth/test/_responses/integration/clerk_auth/sign_up_test/updates_when_there_is_a_change/001.json
shinyford
added a commit
that referenced
this pull request
Oct 20, 2025
shinyford
pushed a commit
that referenced
this pull request
Oct 20, 2025
Unnecessary call updateUser even if the field not changed
shinyford
added a commit
that referenced
this pull request
Oct 20, 2025
shinyford
added a commit
that referenced
this pull request
Oct 20, 2025
slightfoot
pushed a commit
that referenced
this pull request
Oct 20, 2025
* Unnecessary call update user even field not change (#286) Unnecessary call updateUser even if the field not changed * fix: make email link test work [#286] * fix: change test timestamps to make (hopefully) fewer commits [#286] --------- Co-authored-by: Krisada Adoolrattananuwat (Tak) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessary call updateUser even if the field not changed
@fhdeodato @shinyford