Skip to content

Add support for setting primary email, phone, and web3 wallet #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for setting primary email, phone, and web3 wallet #310

wants to merge 4 commits into from

Conversation

@deevus
Copy link
Contributor

@deevus deevus commented Nov 25, 2025

Summary

  • Add primaryEmailAddressId, primaryPhoneNumberId, and primaryWeb3WalletId parameters to Api.updateUser() and Auth.updateUser()
  • Fix firstName comparison bug (was comparing against username instead of firstName)
  • Add comprehensive integration tests for both Auth and API layers

Test plan

  • Auth layer tests for primary email/phone updates
  • API layer tests for primary email/phone updates
  • Web3 wallet tests skipped (requires web3 wallet in test instance)
  • All existing tests pass

Note:
I had to edit the fixtures to differentiate the replaced identifiers

@deevus
feat: support for primary email/phone/web3
9953cdd
@deevus
test: add integration tests for user detail updates
a4c8f3f
@deevus
fix: correct firstName comparison to use firstName instead of username
894fde9 
The validation logic was incorrectly comparing the firstName field against user.username instead of user.firstName. This fix ensures that when checking if the first name has changed, the comparison uses the correct field, preventing false positives in change detection for user profile updates.
@deevus
test: add integration tests for setting primary email and phone number
a80fbf5 
Add comprehensive test coverage for updating user primary contact details through the Clerk API, including:

- Test for changing the primary email address to a secondary email and restoring the original
- Test for changing the primary phone number to a secondary phone and restoring the original
- Mock API response fixtures for both email and phone update workflows
- Validation that primary identifier changes are properly reflected in the user object and client session
@slightfoot slightfoot requested a review from shinyford November 27, 2025 09:58
@slightfoot slightfoot added bug Something isn't working enhancement New feature or request clerk_auth package: clerk_auth clerk_flutter package: clerk_flutter labels Nov 27, 2025
@slightfoot slightfoot added this to the v0.0.14-beta milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinyford shinyford Awaiting requested review from shinyford

Assignees

@shinyford shinyford

Labels

bug Something isn't working clerk_auth package: clerk_auth clerk_flutter package: clerk_flutter enhancement New feature or request

Projects

None yet

Milestone

v0.0.14-beta

Development

Successfully merging this pull request may close these issues.

3 participants

@deevus @shinyford @slightfoot