Skip to content

chore(clerk-js): Reapply Convert all Jest tests to Vitest #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacekradko merged 20 commits into from
Sep 30, 2025
Merged

chore(clerk-js): Reapply Convert all Jest tests to Vitest #6823

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6815aba
feat: convert jest to vitest
jacekradko Sep 25, 2025
77791c6
wip
jacekradko Sep 25, 2025
a916b3b
wip
jacekradko Sep 25, 2025
4918243
wip
jacekradko Sep 25, 2025
d82903d
wip
jacekradko Sep 25, 2025
8616327
add timer button test
jacekradko Sep 25, 2025
8d0cc7b
disable rule causing many false positives
jacekradko Sep 25, 2025
67b2d9d
wip
jacekradko Sep 25, 2025
c86fc81
wip
jacekradko Sep 25, 2025
93ac763
wip
jacekradko Sep 25, 2025
7ff5e2e
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 25, 2025
18f60cb
wip
jacekradko Sep 25, 2025
28cfd77
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 26, 2025
3c85724
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 26, 2025
ebfb123
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 26, 2025
04ad31c
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 27, 2025
2295010
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 27, 2025
70aa109
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 29, 2025
e38048a
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 29, 2025
b8a2a66
Merge branch 'main' into chore/clerk-js-vitest
jacekradko Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/dirty-cows-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 3 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ export default tseslint.config([
jest: pluginJest,
},
rules: {
'@typescript-eslint/await-thenable': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/unbound-method': 'off',
'jest/unbound-method': 'error',
},
Expand Down Expand Up @@ -365,7 +367,7 @@ export default tseslint.config([
},
{
name: 'packages/clerk-js - vitest',
files: ['packages/clerk-js/src/**/*.spec.{ts,tsx}'],
files: ['packages/clerk-js/src/**/*.test.{ts,tsx}'],
rules: {
'jest/unbound-method': 'off',
'@typescript-eslint/unbound-method': 'off',
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"@types/react": "catalog:react",
"@types/react-dom": "catalog:react",
"@vitejs/plugin-react": "^4.5.2",
"@vitest/coverage-v8": "3.0.5",
"@vitest/coverage-v8": "3.2.4",
"chalk": "4.1.2",
"citty": "^0.1.6",
"conventional-changelog-conventionalcommits": "^4.6.3",
Expand Down Expand Up @@ -146,7 +146,7 @@
"typescript-eslint": "8.38.0",
"uuid": "8.3.2",
"verdaccio": "^5.33.0",
"vitest": "3.0.5",
"vitest": "3.2.4",
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Vitest 3.2.4 bump LGTM—ensure lockfile updates.

Looks good. Please run pnpm install to refresh the lockfile and CI cache.

🏁 Script executed:

#!/bin/bash
set -euo pipefail
echo "Checking for vitest versions and lingering Jest deps..."
rg -n -C2 -S '"vitest"\s*:' package.json || true
rg -n -C2 -S '\b(jest|@jest/globals|jest-chrome|jest-environment-jsdom|ts-jest)\b' --glob '!**/node_modules/**' || true

Length of output: 349

#!/bin/bash
set -euo pipefail
echo "Checking for jest-related dependencies in package.json..."
jq -r '((.dependencies // {}) + (.devDependencies // {})) | keys[]' package.json
| grep -Ei '^(jest|@jest/globals|jest-chrome|jest-environment-jsdom|ts-jest)' || echo "No jest deps found"

🏁 Script executed:

#!/bin/bash
set -euo pipefail
echo "Checking for Jest-related dependencies in package.json..."
jq -r '((.dependencies // {}) + (.devDependencies // {})) | keys[]' package.json \
  | grep -E '^(jest|@jest/globals|jest-chrome|jest-environment-jsdom|ts-jest)' \
  || echo "No Jest deps found"

Length of output: 119

Remove lingering Jest dependencies and update lockfile.

  • Delete @jest/globals, jest, jest-chrome, jest-environment-jsdom and ts-jest from package.json.
  • Run pnpm install to refresh the lockfile and CI cache.
🤖 Prompt for AI Agents 
In package.json around line 151, there are lingering Jest-related dependencies
that should be removed; delete entries for @jest/globals, jest, jest-chrome,
jest-environment-jsdom, and ts-jest from package.json, then run pnpm install to
update pnpm-lock.yaml (and CI cache) so the lockfile reflects the removal, and
commit the updated package.json and lockfile.

Copy link
Member

@tmilewski tmilewski Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacekradko Should this be updated?

Copy link
Contributor

@coderabbitai coderabbitai bot Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Member Author

@jacekradko jacekradko Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmilewski No, there are still packages that use jest

"yalc": "1.0.0-pre.53",
"zx": "catalog:repo"
},
Expand Down
62 changes: 0 additions & 62 deletions packages/clerk-js/jest.config.js
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions packages/clerk-js/jest.jsdom-with-timezone.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/clerk-js/jest.setup-after-env.ts
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions packages/clerk-js/jest.setup.ts
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions packages/clerk-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,10 @@
"lint": "eslint src",
"lint:attw": "attw --pack . --profile node16 --ignore-rules named-exports",
"lint:publint": "publint || true",
"test": "jest && vitest --watch=false",
"test:cache:clear": "jest --clearCache --useStderr",
"test:ci": "jest --maxWorkers=70%",
"test:coverage": "jest --collectCoverage && open coverage/lcov-report/index.html",
"test:jest": "jest",
"test": "vitest --watch=false",
"test:sandbox:integration": "playwright test",
"test:sandbox:integration:ui": "playwright test --ui",
"test:sandbox:integration:update-snapshots": "playwright test --update-snapshots",
"test:vitest": "vitest",
"watch": "rspack build --config rspack.config.js --env production --watch"
},
"browserslist": "last 2 years",
Expand Down Expand Up @@ -91,18 +86,16 @@
},
"devDependencies": {
"@clerk/testing": "workspace:^",
"@emotion/jest": "^11.13.0",
"@rsdoctor/rspack-plugin": "^0.4.13",
"@rspack/cli": "^1.4.11",
"@rspack/core": "^1.4.11",
"@rspack/plugin-react-refresh": "^1.5.0",
"@svgr/webpack": "^6.5.1",
"@swc/jest": "0.2.39",
"@types/cloudflare-turnstile": "^0.2.2",
"@types/node": "^22.18.6",
"@types/webpack-env": "^1.18.8",
"bundlewatch": "^0.4.1",
"jsdom": "^24.1.3",
"jsdom": "26.1.0",
"minimatch": "^10.0.3",
"webpack-merge": "^5.10.0"
},
Expand Down
0 ...s/clerk-js/src/__tests__/headless.spec.ts → ...s/clerk-js/src/__tests__/headless.test.ts
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion ...rc/core/__tests__/clerk.redirects.spec.ts → ...rc/core/__tests__/clerk.redirects.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const mockEnvironmentFetch = vi.fn();
vi.mock('../resources/Client');
vi.mock('../resources/Environment');

// Because Jest, don't ask me why...
vi.mock('../auth/devBrowser', () => ({
createDevBrowser: (): DevBrowser => ({
clear: vi.fn(),
Expand Down
Loading
Loading