Skip to content

test(e2e): Update tests to handle untrusted password on sign-in #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2025
Merged

test(e2e): Update tests to handle untrusted password on sign-in #7345

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2e344e
test(e2e): Update tests to handle untrusted password on sign-in
octoper Dec 2, 2025
6b2ffb5
Add empty changeset
octoper Dec 2, 2025
ccce693
Enhance tests to handle untrusted password error
octoper Dec 2, 2025
387f762
fix(e2e): Grab the correct error message
octoper Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changeset/funny-crabs-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---

---
18 changes: 14 additions & 4 deletions integration/tests/session-tasks-sign-in-reset-password.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { test } from '@playwright/test';
import { expect, test } from '@playwright/test';

import { hash } from '../models/helpers';
import { appConfigs } from '../presets';
Expand Down Expand Up @@ -28,6 +28,10 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasksResetPassword
await u.po.signIn.setPassword(user.password);
await u.po.signIn.continue();

await expect(u.page.getByTestId('form-feedback-error')).toBeVisible();
await u.po.signIn.getUseAnotherMethodLink().click();
await u.po.signIn.getAltMethodsEmailCodeButton().click();

await u.page.getByRole('textbox', { name: 'code' }).click();
await u.page.keyboard.type('424242', { delay: 100 });

Expand Down Expand Up @@ -62,7 +66,8 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasksResetPassword
await u.services.users.passwordUntrusted(createdUser.id);
const fakeOrganization = u.services.organizations.createFakeOrganization();
await u.services.organizations.createBapiOrganization({
...fakeOrganization,
name: fakeOrganization.name,
slug: fakeOrganization.slug + Date.now().toString(),
createdBy: createdUser.id,
});

Expand All @@ -73,9 +78,14 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasksResetPassword
await u.po.signIn.setPassword(user.password);
await u.po.signIn.continue();

await u.page.getByRole('textbox', { name: 'code' }).fill('424242');
await expect(u.page.getByTestId('form-feedback-error')).toBeVisible();

await u.po.signIn.getUseAnotherMethodLink().click();

await u.po.signIn.getAltMethodsEmailCodeButton().click();

await u.po.expect.toBeSignedIn();
await u.page.getByRole('textbox', { name: 'code' }).click();
await u.page.keyboard.type('424242', { delay: 100 });

// Redirects back to tasks when accessing protected route by `auth.protect`
await u.page.goToRelative('/page-protected');
Expand Down
Loading