Skip to content

store the session on the storage #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whoiskatrin merged 7 commits into from
Oct 21, 2025
Merged

store the session on the storage #121

whoiskatrin merged 7 commits into from
Oct 21, 2025

Conversation

@whoiskatrin
Copy link
Collaborator

@whoiskatrin whoiskatrin commented Oct 20, 2025 •
edited
Loading

Changes

  • Load session ID from storage on initialization
  • Persist session ID when created
  • Gracefully handle existing sessions

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a8685a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@whoiskatrin whoiskatrin marked this pull request as ready for review October 21, 2025 08:54
ghostwriternr
ghostwriternr approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@ghostwriternr ghostwriternr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment regarding the new preview package workflow, but the main change looks good and can be merged. We can fix the workflow in a separate PR.

.github/workflows/pkg-pr-new.yml
run: npx tsx .github/resolve-workspace-versions.ts

- name: Publish to pkg.pr.new
run: npx pkg-pr-new publish './packages/sandbox'
Copy link
Member

@ghostwriternr ghostwriternr Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify this workflow to also include the docker publish, so that preview packages also come with a corresponding image that can be used for testing.

@whoiskatrin whoiskatrin merged commit c77ae8b into main Oct 21, 2025
10 of 13 checks passed
@ghostwriternr ghostwriternr deleted the session-exists-fix branch October 21, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghostwriternr ghostwriternr ghostwriternr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whoiskatrin @ghostwriternr