Skip to content

Remove unnecessary existing session check #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostwriternr merged 2 commits into from
Oct 23, 2025
Merged

Remove unnecessary existing session check #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99843dd
Remove unnecessary existing session check
ghostwriternr Oct 23, 2025
22361a0
Add changeset
ghostwriternr Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-beds-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/sandbox": patch
---

Remove unnecessary existing session check
2 changes: 1 addition & 1 deletion packages/sandbox/src/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ export class Sandbox<Env = unknown> extends Container<Env> implements ISandbox {
this.logger.debug('Default session initialized', { sessionId });
} catch (error: any) {
// If session already exists (e.g., after hot reload), reuse it
if (error?.message?.includes('already exists') || error?.message?.includes('Session')) {
if (error?.message?.includes('already exists')) {
this.logger.debug('Reusing existing session after reload', { sessionId });
this.defaultSession = sessionId;
// Persist to storage in case it wasn't saved before
Expand Down