Fix: token parsing bug causing proxyToSandbox to fail #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes token validation failure due to incorrect token extraction from url logic.
The tokens for port are always generated to be 16 bytes, but the regex in extractSandboxRoute
greedly extracts sandbox id and token from the url, and if the token has '-', it can parse it incorrectly.
for example, here is a generated url:
8001-45sysyjmojksu4la7n4va-n_a-ydoam7w_32y5.vibecoder.cloudflare.dev
Before (incorrect parsing):
Port: 8001
Sandbox ID: 45sysyjmojksu4la7n4va-n_a ← absorbed part of token!
Token: ydoam7w_32y5 ← only 12 chars (invalid)
Result: Token validation fails with "Invalid token" error
After (correct parsing):
Port: 8001
Sandbox ID: 45sysyjmojksu4la7n4va
Token: n_a-ydoam7w_32y5 ← full 16 chars (valid)
Result: Token validation succeeds
Changes:
- Non-greedy sandbox ID pattern: [^.]*? instead of [^.]*
- Exact token length: {16} matches generatePortToken() output
- Lowercase only: [a-z] matches .toLowerCase() in token generation
🦋 Changeset detectedLatest commit: bedd891 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes token validation failure due to incorrect token extraction from url logic. The tokens for port are always generated to be 16 bytes, but the regex in extractSandboxRoute greedly extracts sandbox id and token from the url, and if the token has '-', it can parse it incorrectly. for example, here is a generated url:
8001-45sysyjmojksu4la7n4va-n_a-ydoam7w_32y5.vibecoder.cloudflare.dev
The original sandbox id provided was: 45sysyjmojksu4la7n4va
Before (incorrect parsing):
Port: 8001
Sandbox ID: 45sysyjmojksu4la7n4va-n_a ← absorbed part of token
Token: ydoam7w_32y5 ← only 12 chars (invalid)
Result: Token validation fails with "Invalid token" error
After (correct parsing):
Port: 8001
Sandbox ID: 45sysyjmojksu4la7n4va
Token: n_a-ydoam7w_32y5 ← full 16 chars (valid)
Result: Token validation succeeds
Changes: