Skip to content

Conversation

@ghostwriternr
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: 25bc435

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostwriternr ghostwriternr merged commit f6a5c3e into main Oct 24, 2025
5 of 6 checks passed
@ghostwriternr ghostwriternr deleted the fix-version-bump branch October 24, 2025 13:32
@claude
Copy link
Contributor

claude bot commented Oct 24, 2025

Claude Code Review

Issue: Version rollback appears incorrect

This PR rolls back the version from 0.5.0 to 0.4.7 across all references. However, the changeset describes a bug fix ("Fix token extraction regex causing Invalid token errors"), which should typically be published as a new patch version (e.g., 0.5.1), not a rollback to an older version.

Concerns:

  1. Rollback justification unclear: The PR title says "Fix version bump" but doesn't explain why we're going backwards. Was 0.5.0 published incorrectly? Was it never released? The CHANGELOG.md removal suggests 0.5.0 may have been a mistake.

  2. Changeset describes future fix: The changeset file describes fixing "token extraction regex causing Invalid token errors" - this fix should be in the codebase somewhere but isn't shown in this PR. Is this PR just correcting version numbers, with the actual fix coming in a separate PR?

  3. Version consistency: The package-lock.json shows extensive dependency tree changes (peer dependencies being added/removed) which seems unusual for a pure version number correction.

Questions to clarify:

  • Was 0.5.0 accidentally published or never released?
  • Does the codebase currently contain the token extraction regex fix mentioned in the changeset?
  • Should the changeset be removed if this is purely reverting an incorrect version bump?

If 0.5.0 was never published: This PR is fine - it's correcting a premature version bump. Consider adding context to the PR description.

If 0.5.0 was published: Rolling back version numbers after publishing is problematic for semantic versioning and can break existing users on 0.5.0.

@threepointone threepointone mentioned this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant