-
Notifications
You must be signed in to change notification settings - Fork 46
Fix type generation #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type generation #168
Conversation
We inline types from `@repo/shared` so that it includes the types we reexport. Fixes #165 Updated tsup to tsdown, and normalized some deps. Added typecheck steps to example repos (except basic, so that CI passes for this one). I'll do more monorepo maintenance after this change lands.
🦋 Changeset detectedLatest commit: 6132685 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Claude Code ReviewSummary: This PR effectively fixes issue #165 by switching from Key Changes:
Architecture Alignment: ✅ Issues:
Minor Observations:
Recommendation: Approve after addressing issue #1. Issue #2 is non-blocking but should be tracked separately. |
ghostwriternr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, needs a minor change so we don't break c3 + tutorials
commit: |
🐳 Docker Image PublishedFROM cloudflare/sandbox:0.0.0-pr-168-6b72c1aVersion: You can use this Docker image with the preview package from this PR. |
We inline types from
@repo/sharedso that it includes the types we reexport. Fixes #165Updated tsup to tsdown, and normalized some deps. Added typecheck steps to example repos (except basic, so that CI passes for this one). I'll do more monorepo maintenance after this change lands.