Skip to content

Conversation

@ghostwriternr
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: b7046e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ghostwriternr ghostwriternr merged commit f06fee3 into main Oct 30, 2025
6 checks passed
@ghostwriternr ghostwriternr deleted the feat/external-pr-approval-workflow branch October 30, 2025 16:59
@claude
Copy link
Contributor

claude bot commented Oct 30, 2025

Claude Code Review

Issue: Broken CONTRIBUTING.md link in README

The README.md link to CONTRIBUTING.md (line 121) is incorrect:

See [CONTRIBUTING.md](./CONTRIBUTING.md) for guidelines

This path won't work because CONTRIBUTING.md is at the repository root, but the README is in packages/sandbox/. The link should be:

See [CONTRIBUTING.md](../../CONTRIBUTING.md) for guidelines

Node version mismatch

CONTRIBUTING.md:9 states "Node.js 24+" but the project actually uses Node.js 20 LTS according to CLAUDE.md ("Node.js 20 LTS"). The workflows also use node-version: 24. This should be clarified - either the project has upgraded to Node 24 (update CLAUDE.md) or CONTRIBUTING.md should say Node 20+ (match current reality).

Otherwise looks good

The CI workflow changes properly gate external PRs with the 'ci' label while allowing internal PRs to run automatically - good security practice. The CONTRIBUTING guide is well-structured and helpful.

@github-actions
Copy link
Contributor

🐳 Docker Image Published

FROM cloudflare/sandbox:0.0.0-pr-179-50121a7

Version: 0.0.0-pr-179-50121a7

You can use this Docker image with the preview package from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant