Sandbox site #236

threepointone · 2025-11-19T22:49:18Z

No description provided.

changeset-bot · 2025-11-19T22:49:21Z

⚠️ No Changeset found

Latest commit: ad9cfe3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

claude

Claude Code Review

This PR adds an Astro-based marketing site to the repository. The site code looks solid, but there are several integration issues to address before merge.

Critical Issues

1. Duplicate font files (~1.95 MB wasted)

Font files exist in three locations:

sites/sandbox/fonts/ (704KB)
sites/sandbox/public/fonts/ (704KB)
sites/sandbox/public/inter/ (548KB)

Only public/fonts/ is needed for Astro. Remove the other two directories.

2. Incorrect .gitignore pattern

Line 161 has site/*/.astro/*.* but should be sites/*/.astro/*.* (plural). The current pattern won't ignore Astro build artifacts.

3. nanoid v3 → v5 (breaking change)

The examples/openai-agents/package.json jumps from nanoid 3.x to 5.x. This is ESM-only and may break the example. Has this been tested?

4. Missing deployment strategy

No CI workflow exists for the site, and the Cloudflare adapter is commented out in astro.config.ts. How is this deployed? Static build to Pages or SSR to Workers?

Important Issues

5. Biome version pinning

package.json:28 changes ^2.3.5 to 2.3.5 (removes caret). Is this intentional? This prevents automatic patch updates.

6. Type error suppression

sites/sandbox/astro.config.ts:16 has @ts-expect-error with a TODO. Either fix the type error properly or document why it's unavoidable.

7. Missing documentation

CLAUDE.md and root README don't mention the new sites/ workspace. Add a section explaining:

Purpose of the site
How to develop/deploy it
Build commands

8. No changeset

Does this change affect the published @cloudflare/sandbox package? If so, you'll need a changeset file in .changeset/.

Minor Issues

sites/sandbox/README.md mentions "IBM Plex Mono" but the actual custom font is "PP Mondwest" (loaded locally)
No test coverage or build verification in CI for the new site
SVG files in public/ could be optimized

Verdict

Needs fixes before merge. The site itself is well-structured, but the monorepo integration needs work:

Remove duplicate fonts
Fix gitignore pattern
Verify nanoid v5 compatibility
Clarify deployment strategy (add CI workflow or document manual process)
Document the site in CLAUDE.md
Fix or explain the type error suppression

.gitignore

claude · 2025-11-19T22:53:49Z

package.json

  ],
  "devDependencies": {
-    "@biomejs/biome": "^2.3.5",
+    "@biomejs/biome": "2.3.5",


Biome version changed from ^2.3.5 to 2.3.5 (exact pin). Is this intentional? It prevents automatic patch updates.

Issue persists in this PR. Still seeing exact version 2.3.5 instead of ^2.3.5. This blocks patch updates for security and bug fixes.

Issue persists. Biome remains at exact version 2.3.5 instead of ^2.3.5. However, for a linter this is acceptable for consistency across developer machines.

claude · 2025-11-19T22:53:50Z

examples/openai-agents/package.json

  "dependencies": {
    "@openai/agents": "^0.3.2",
-    "nanoid": "^3.3.11",
+    "nanoid": "^5.1.6",


nanoid v3 → v5 is a major version jump. v4+ is ESM-only. Has this example been tested with the new version?

Still seeing nanoid v5.1.6 in this PR. Since v4+ is ESM-only, this needs testing verification in the Workers environment. The lockfile shows both v3 and v5 coexist in the dependency tree.

nanoid v5 still present but this is acceptable. The openai-agents example uses "type": "module" so ESM-only dependencies are fine.

pkg-pr-new · 2025-11-19T22:59:52Z

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@236

commit: 1d12c25

github-actions · 2025-11-19T22:59:53Z

🐳 Docker Image Published

FROM cloudflare/sandbox:0.0.0-pr-236-366816f

Version: 0.0.0-pr-236-366816f

You can use this Docker image with the preview package from this PR.

claude

Claude Code Review

The .gitignore pattern is fixed. However, previous issues remain and new critical problems emerged.

Critical Issues

1. Duplicate Font Files (NEW)
Font files exist in THREE locations consuming ~2MB:

sites/sandbox/fonts/ (704KB)
sites/sandbox/public/fonts/ (704KB)
sites/sandbox/public/inter/ (552KB)

Keep only public/fonts/ and delete the other two directories.

2. Missing Changeset (NEW)
No changeset despite adding a new sites/* workspace. CLAUDE.md requires changesets for all changes. Either create one or clarify that sites don't require changesets since they're not published.

Previous Issues Still Present

Biome exact pin: Still "2.3.5" instead of ^2.3.5 at package.json:28. This prevents patch updates. Needs rationale or fix.

nanoid v3 → v5: Major version jump (ESM-only in v4+) in examples/openai-agents. Has this been tested in Workers environment?

Additional Issues

Inconsistent config: Astro adapter commented out but dependency included (sites/sandbox/astro.config.ts:2-14)
README inaccuracies: Claims "IBM Plex Mono" but uses Inter/PP Mondwest fonts
TypeScript error suppressed: @ts-expect-error without explanation (astro.config.ts:16)
Missing site .gitignore: No local .gitignore for Astro artifacts
CLAUDE.md gap: Sites directory not documented

Verdict

NOT READY TO MERGE. Fix duplicate fonts, resolve Biome pinning, add changeset or document exemption, verify nanoid compatibility.

claude · 2025-11-19T23:25:25Z

sites/sandbox/astro.config.ts

+export default defineConfig({
+  integrations: [react()],
+  output: 'static',
+  // adapter: cloudflare({


Cloudflare adapter is commented out but the dependency is in package.json. Either enable it with SSR output, or remove @astrojs/cloudflare from dependencies.

claude · 2025-11-19T23:25:25Z

sites/sandbox/astro.config.ts

+  //   }
+  // }),
+  vite: {
+    // @ts-expect-error - TODO we need to fix this


@ts-expect-error without explanation. Either fix the type issue or document why this is acceptable with a clear TODO.

claude · 2025-11-19T23:25:26Z

sites/sandbox/README.md

+
+- **React 19** - UI library
+- **TypeScript** - Type safety
+- **Vite** - Build tool and dev server


Tech stack claims IBM Plex Mono but the repo contains Inter and PP Mondwest fonts. Update to match actual fonts used.

Update: README correctly lists Inter and IBM Plex Mono. The issue is that unused PP Mondwest font files exist in sites/sandbox/public/fonts/pp-mondwest/ but are never referenced in code. These should be removed.

Uninstalled @astrojs/cloudflare and removed related configuration from astro.config.ts and package.json in the sandbox site. This simplifies the setup and removes Cloudflare-specific deployment code.

claude

Claude Code Review

Previous review issues largely remain unaddressed, but most are acceptable for a marketing site.

Critical issue: README claims "Inter & IBM Plex Mono" fonts, which is correct, but unused PP Mondwest font files exist in the repo (sites/sandbox/public/fonts/pp-mondwest/). These should be removed to reduce bloat.

Other findings:

Biome exact pin (2.3.5) is acceptable for linter consistency
nanoid v5 in openai-agents example is fine (ESM-only but example uses "type": "module")
@ts-expect-error in astro.config.ts:10 is documented as TODO, acceptable
No tests for site is reasonable for static marketing content
Cloudflare adapter commented out with dependency still present is minor

Architectural decision: Including marketing site in SDK monorepo follows industry patterns (Next.js, Vite). Properly isolated via workspaces.

Needs follow-up PR to remove unused PP Mondwest fonts from sites/sandbox/public/fonts/pp-mondwest/.

threepointone added 2 commits November 19, 2025 20:56

bring the sandbox site to the main repo

bedecd3

rewrite in astro

2805093

claude bot reviewed Nov 19, 2025

View reviewed changes

add astro gen files to gitignore

1d12c25

claude bot reviewed Nov 19, 2025

View reviewed changes

Remove @astrojs/cloudflare integration from sandbox

ad9cfe3

Uninstalled @astrojs/cloudflare and removed related configuration from astro.config.ts and package.json in the sandbox site. This simplifies the setup and removes Cloudflare-specific deployment code.

threepointone merged commit 842176d into main Nov 19, 2025
5 checks passed

threepointone deleted the sandbox-site branch November 19, 2025 23:28

claude bot reviewed Nov 19, 2025

View reviewed changes

Sandbox site #236

Sandbox site #236

Uh oh!

Conversation

threepointone commented Nov 19, 2025

Uh oh!

changeset-bot bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Critical Issues

Important Issues

Minor Issues

Verdict

Uh oh!

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐳 Docker Image Published

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Critical Issues

Previous Issues Still Present

Additional Issues

Verdict

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Nov 19, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading