Skip to content

Conversation

@mattzcarey
Copy link
Contributor

also fixes indenting on all the examples to make them consistent

Before:

Screenshot 2025-11-23 at 14 32 25 Screenshot 2025-11-23 at 14 32 30 Screenshot 2025-11-23 at 14 32 35

After:

Screenshot 2025-11-23 at 14 32 44 Screenshot 2025-11-23 at 14 32 50 Screenshot 2025-11-23 at 14 32 56

Added overflow-auto classes to websocket example code block and CodeBlock component to prevent content from overflowing container boundaries. Removed flex centering classes from CodeBlock that were causing layout issues with scrollable content.
@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: aaa98ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Inconsistency issue: The websocketExample now has max-w-full overflow-auto classes, but other examples (nodeExample, processingExample, filesExample, exposeExample) use max-w-full max-h-full overflow-auto. The pythonExample (code-sample.tsx:204) has no overflow classes at all.

Recommendation: For consistency across all code examples:

  1. Add max-h-full to websocketExample to match the pattern used in other examples
  2. Add overflow classes to pythonExample so all examples handle overflow consistently

The grid.tsx padding and overflow changes look good.

Needs minor consistency fix before merge.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@239

commit: aaa98ea

@github-actions
Copy link
Contributor

🐳 Docker Image Published

FROM cloudflare/sandbox:0.0.0-pr-239-7cf9773

Version: 0.0.0-pr-239-7cf9773

You can use this Docker image with the preview package from this PR.

@threepointone threepointone merged commit ac185f1 into main Nov 23, 2025
13 checks passed
@threepointone threepointone deleted the fix-websocket-example branch November 23, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants