Remove output size limit for command execution #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 10MB output size limit was overly defensive and caused unexpected errors when reading large files. Trust developers to manage their own resource usage. Changes: - Remove size check from parseLogFile in session.ts - Remove MAX_OUTPUT_SIZE_BYTES from config.ts - Remove maxOutputSizeBytes from SessionOptions - Update tests to verify large output works - Update documentation Fixes #255 Co-authored-by: Naresh <[email protected]>
🦋 Changeset detectedLatest commit: e141248 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
🐳 Docker Image PublishedFROM cloudflare/sandbox:0.0.0-pr-256-dfecdd3Version: You can use this Docker image with the preview package from this PR. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
The 10MB output size limit was overly defensive and caused unexpected errors when reading large files. This PR removes the limit to trust developers to manage their own resource usage.
Changes
parseLogFile()in session.tsMAX_OUTPUT_SIZE_BYTESfrom config.tsmaxOutputSizeBytesfromSessionOptionsTesting
🤖 Generated with Claude Code