Fix type error when extending Sandbox class #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes type error when extending Sandbox class. DurableObjectNamespace<T> is invariant, so getSandbox needed to be generic to accept subclass namespaces.
🦋 Changeset detectedLatest commit: 00bbd01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
🐳 Docker Images PublishedDefault (no Python): FROM cloudflare/sandbox:0.0.0-pr-264-03385c9With Python: FROM cloudflare/sandbox:0.0.0-pr-264-03385c9-pythonVersion: Use the |
agents-git-bot bot
pushed a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Dec 1, 2025
Update API documentation to reflect TypeScript generic type parameters added to getSandbox(), SandboxEnv, and proxyToSandbox(). These changes fix type errors when extending the Sandbox class with custom methods. Changes: - Update getSandbox() signature to show generic type parameter - Add section on extending Sandbox class with example - Document proxyToSandbox() function with generic types - Document SandboxEnv type helper for custom Sandbox classes Related to cloudflare/sandbox-sdk#264 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
generally should we use unknown instead of any?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users extending
Sandboxto add custom methods would get a type error when passing their namespace togetSandbox(). TypeScript's generic invariance meant the function couldn't accept subclass namespaces.getSandboxandSandboxEnvare now generic to properly support extended classes.Fixes #262