Add a Score counter to task overview #1476

pxsit · 2025-07-23T13:51:41Z

Add a Score counter to task overview

prandla · 2025-07-23T14:11:12Z

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.

Does anyone else have any thoughts?

Muaath5 · 2025-07-28T07:59:48Z

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.

Does anyone else have any thoughts?

I don't see any issues if both of these ways where implemented, but if it was in the task overview it would be better in case of onsite competitions and you don't want others to look into your score :)

pxsit · 2025-08-01T10:41:47Z

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.
Does anyone else have any thoughts?

I don't see any issues if both of these ways where implemented, but if it was in the task overview it would be better in case of onsite competitions and you don't want others to look into your score :)

Added an option to toggle this in AWS (:

cms/server/contest/handlers/main.py

cms/server/contest/static/cws_style.css

cmscontrib/updaters/update_from_1.5.sql

cms/server/contest/templates/overview.html

Reformat, Fix Updaters, more

cms/server/contest/templates/overview.html

cms/server/contest/static/cws_style.css

cms/server/contest/handlers/main.py

pxsit · 2025-08-04T15:07:08Z

Im still getting this bug, let me try fix it

pxsit · 2025-08-04T15:41:33Z

Should be fixed! (According to my testing)

prandla · 2025-08-04T19:26:14Z

Sorry, I just looked at the rest of cws_style.css, and now I think your original approach was the best... I thought the places you changed were the only places that defined these colors, but looks like there are quite a few other places that use slightly different colors, so explicitly defining that these colors are in the task overview table and in the submission list table is fine.

After reverting that it should be good to merge.

Looks cursed having it not in order

codecov · 2025-11-17T12:15:50Z

Codecov Report

❌ Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.64%. Comparing base (4cdaa00) to head (6411ec3).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
cms/server/contest/handlers/main.py	21.05%	15 Missing ⚠️
cms/server/admin/handlers/contest.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   54.67%   54.64%   -0.04%     
==========================================
  Files         335      335              
  Lines       27361    27381      +20     
==========================================
+ Hits        14960    14962       +2     
- Misses      12401    12419      +18

Flag	Coverage Δ
functionaltests	`0.00% <0.00%> (ø)`
unittests	`54.64% <23.80%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This pull request adds a configurable score counter display to the task overview page in the Contest Web Server (CWS). The feature is controlled by a new boolean field show_task_scores_in_overview that can be configured per contest.

Adds database column show_task_scores_in_overview to the contests table with default value of true
Implements score calculation and display in the task overview table
Extends CSS styling to apply score coloring (red/yellow/green) to the task overview scores

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
cmscontrib/updaters/update_from_1.5.sql	Adds database migration to create the `show_task_scores_in_overview` column in the contests table
cms/server/contest/templates/overview.html	Adds conditional score column header and data cells to the task overview table
cms/server/contest/static/cws_style.css	Extends existing score styling classes to also apply to the main task list
cms/server/contest/handlers/main.py	Implements score calculation logic in `MainHandler.render_params()` and adds necessary imports
cms/server/admin/templates/contest.html	Adds checkbox UI element for the new setting in the contest configuration page
cms/server/admin/handlers/contest.py	Adds form processing for the new `show_task_scores_in_overview` field
cms/db/contest.py	Adds the `show_task_scores_in_overview` boolean column definition to the Contest model

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-01T07:01:55Z

cms/server/contest/handlers/main.py

    """
    @multi_contest
    def get(self):
+        self.r_params = self.render_params()


The assignment to self.r_params in the get method is unnecessary and could cause confusion. The parent class ContestHandler.prepare() method already calls self.render_params() and assigns the result to self.r_params at line 104 of contest.py. This line should be removed and the code should simply call self.render("overview.html", **self.r_params) directly.

Suggested change

self.r_params = self.render_params()

Copilot · 2026-01-01T07:01:56Z

cms/server/contest/handlers/main.py

+            # This massive joined load gets all the information which we will need
+            participation = (
+                self.sql_session.query(Participation)
+                .filter(Participation.id == self.current_user.id)
+                .options(
+                    joinedload(Participation.user),
+                    joinedload(Participation.contest),
+                    joinedload(Participation.submissions).joinedload(Submission.token),
+                    joinedload(Participation.submissions).joinedload(
+                        Submission.results
+                    ),
+                )
+                .first()
+            )


This code queries the Participation object again even though it should already be available via self.current_user (which is set by the parent class's get_current_user() method). Additionally, the parent class's render_params() method already queries the participation and sets it in the render params at line 210-211 of contest.py. This duplicate query with extensive joins could negatively impact performance and is unnecessary.

Suggested change

# This massive joined load gets all the information which we will need

participation = (

self.sql_session.query(Participation)

.filter(Participation.id == self.current_user.id)

.options(

joinedload(Participation.user),

joinedload(Participation.contest),

joinedload(Participation.submissions).joinedload(Submission.token),

joinedload(Participation.submissions).joinedload(

Submission.results

),

)

.first()

)

# Reuse the participation already loaded by the parent class instead of

# issuing another heavy query here.

participation = ret.get("participation") or self.current_user

Copilot · 2026-01-01T07:01:56Z

cms/server/contest/handlers/main.py

+            self.contest = (
+                self.sql_session.query(Contest)
+                .filter(Contest.id == participation.contest.id)
+                .options(joinedload(Contest.tasks).joinedload(Task.active_dataset))
+                .first()
+            )


This code queries the Contest object again and assigns it to self.contest, even though self.contest is already set by the parent class's choose_contest() method (called in prepare() at line 85 of contest.py). This duplicate query is unnecessary and could cause confusion about which contest object is being used. The existing self.contest should be used instead, and if additional related data needs to be loaded, it should be done through appropriate joins or queries without reassigning self.contest.

Copilot · 2026-01-01T07:01:56Z

cms/server/contest/handlers/main.py

+            ret["participation"] = participation
+


The code overwrites ret["participation"] which is already set by the parent class's render_params() method at line 211 of contest.py. This is redundant and could cause confusion about which participation object is being used in the template.

Suggested change

ret["participation"] = participation

Copilot · 2026-01-01T07:01:56Z

cms/server/contest/templates/overview.html

    </colgroup> -->
    <thead>
        <tr>
+{% if contest.show_task_scores_in_overview %}


There's an inconsistency in the conditional logic that could cause table column misalignment. Line 196 adds a Score header column when contest.show_task_scores_in_overview is true, but line 215 only adds the score data cell when both contest.show_task_scores_in_overview and task_scores is defined are true. This means if show_task_scores_in_overview is enabled but task_scores is not defined (e.g., when current_user is None), the table will have a Score header but no corresponding data cells, causing a column mismatch. Both conditions should use the same check: contest.show_task_scores_in_overview and task_scores is defined.

Suggested change

{% if contest.show_task_scores_in_overview %}

{% if contest.show_task_scores_in_overview and task_scores is defined %}

Copilot · 2026-01-01T07:01:57Z

cms/server/contest/handlers/main.py


 from cms import config
-from cms.db import User, Participation, Team
+from cms.db import User, Participation, Team, Submission, Token, Task, Dataset


Import of 'Token' is not used.
Import of 'Dataset' is not used.

Suggested change

from cms.db import User, Participation, Team, Submission, Token, Task, Dataset

from cms.db import User, Participation, Team, Submission, Task

pxsit added 2 commits July 23, 2025 20:50

Add a Score counter to task overview

bb17b1a

Add a Score counter to task overview

Merge branch 'main' into add-counter

6653f15

pxsit added 2 commits July 23, 2025 22:04

Merge branch 'main' into add-counter

3d62b5d

Merge branch 'main' into add-counter

6b52ff7

pxsit added 3 commits August 1, 2025 17:03

Merge branch 'main' into add-counter

8428046

Restore Formatting, Make it toggleable

4ae18e9

Fix color not displaying

cbe5f8e

prandla requested changes Aug 3, 2025

View reviewed changes

Fix

8055bf6

Reformat, Fix Updaters, more

prandla requested changes Aug 3, 2025

View reviewed changes

cms/server/contest/templates/overview.html Outdated Show resolved Hide resolved

cms/server/contest/static/cws_style.css Show resolved Hide resolved

prandla reviewed Aug 4, 2025

View reviewed changes

cms/server/contest/handlers/main.py Outdated Show resolved Hide resolved

Fix the Fix

fc50113

Fix the Fix that Fix the Fix

251c8b5

pxsit added 2 commits August 5, 2025 17:10

Merge branch 'main' into add-counter

527bdea

Update cws_style.css

95cc100

prandla approved these changes Aug 5, 2025

View reviewed changes

pxsit added 8 commits August 5, 2025 21:04

Merge branch 'main' into add-counter

e60f328

Add credit for original owner?

13c491e

Merge branch 'main' into add-counter

95349b0

Merge branch 'main' into add-counter

28c1ae1

Update update_from_1.5.sql

e0840f6

Looks cursed having it not in order

Merge branch 'main' into add-counter

a958b48

Merge branch 'main' into add-counter

7a3b7b7

Merge branch 'main' into add-counter

fa4e7ca

pxsit added 5 commits August 16, 2025 23:08

Merge branch 'main' into add-counter

4b0bd83

Merge branch 'cms-dev:main' into add-counter

d12ba11

Merge branch 'cms-dev:main' into add-counter

85d0eb8

Merge branch 'cms-dev:main' into add-counter

3181514

Merge branch 'cms-dev:main' into add-counter

003a7f9

prandla mentioned this pull request Nov 1, 2025

Feat: Add score highlighting and visibility to contest overview #1581

Closed

pxsit added 2 commits November 17, 2025 20:04

Remove unused PrintJob import from main.py

7aac12b

Merge branch 'main' into add-counter

1134711

Merge branch 'main' into add-counter

6411ec3

Copilot AI review requested due to automatic review settings January 1, 2026 06:58

Copilot started reviewing on behalf of pxsit January 1, 2026 06:58 View session

Copilot AI reviewed Jan 1, 2026

View reviewed changes

	{% if contest.show_task_scores_in_overview %}
	{% if contest.show_task_scores_in_overview and task_scores is defined %}

	from cms.db import User, Participation, Team, Submission, Token, Task, Dataset
	from cms.db import User, Participation, Team, Submission, Task

Add a Score counter to task overview #1476

Are you sure you want to change the base?

Add a Score counter to task overview #1476

Uh oh!

Conversation

pxsit commented Jul 23, 2025

Uh oh!

prandla commented Jul 23, 2025

Uh oh!

Muaath5 commented Jul 28, 2025

Uh oh!

pxsit commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pxsit commented Aug 4, 2025

Uh oh!

pxsit commented Aug 4, 2025

Uh oh!

prandla commented Aug 4, 2025

Uh oh!

codecov bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 17, 2025 •

edited

Loading