feat: add all branches as default capability to test analytics page #3928
Conversation
Bundle ReportChanges will increase total bundle size by 61 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 61 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.02%
==========================================
Files 828 828
Lines 15099 15099
Branches 4325 4318 -7
==========================================
- Hits 14893 14891 -2
- Misses 198 200 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.02%
==========================================
Files 828 828
Lines 15099 15099
Branches 4317 4326 +9
==========================================
- Hits 14893 14891 -2
- Misses 198 200 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.02%
==========================================
Files 828 828
Lines 15099 15099
Branches 4317 4318 +1
==========================================
- Hits 14893 14891 -2
- Misses 198 200 +2
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
+ Coverage 96.56% 98.62% +2.05%
==========================================
Files 828 828
Lines 15099 15099
Branches 4325 4318 -7
==========================================
+ Hits 14580 14891 +311
+ Misses 464 200 -264
+ Partials 55 8 -47
... and 43 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
...ages/RepoPage/FailedTestsTab/FailedTestsPage/hooks/useFlakeAggregates/useFlakeAggregates.tsx
Show resolved
Hide resolved
| ordering: getSortingOption(sorting), | ||
| filters: { | ||
| branch: branch ? getDecodedBranch(branch) : undefined, | ||
| branch: branch ? getDecodedBranch(branch) : null, |
There was a problem hiding this comment.
how come this is null vs. undefined now?
ajay-sentry
left a comment
ajay-sentry
left a comment
There was a problem hiding this comment.
played around on preview deploy, had a small question for you about reset to default behavior and the null/undefined thing. Otherwise lgtm
|
Lets also link the ticket too before merge! |
|
@ajay-sentry, this is basically the new behavior: instead of defaulting to the default branch, we'll default to "all branches", which we treat as null in the backend and as empty in the URL route. Hence why we're explicitly defining as null |
Description
This PR adds changes so that the default value for TA pages is "All Branches" instead of the default branch.