fix(billing): Fix update address raise error #298
Conversation
|
@suejung-sentry How does this look on the UI when an error is raised? |
suejung-sentry
force-pushed
the
sshin/billing
branch
from
070f82f to
22fe994
Compare
Here's the fix on gazebo side and a screenshot there - codecov/gazebo#3909 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 1230 1230
Lines 45306 45307 +1
Branches 1449 1449
=======================================
+ Hits 42732 42733 +1
Misses 2270 2270
Partials 304 304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| retrieve_customer_mock, | ||
| ): | ||
| owner = OwnerFactory(stripe_customer_id="123", stripe_subscription_id="123") | ||
| assert self.stripe.update_billing_address(owner, "John Doe", "gabagool") is None |
There was a problem hiding this comment.
this test was failing in CI dunno, was giving error about missing API key again. So changed it to take mocks for the calls to stripe api and still tests invalid address scenario
.vscode/extensions.json
Outdated
| "recommendations": [ | ||
| "ms-python.python", | ||
| "ms-python.mypy-type-checker", | ||
| "elagil.pre-commit-helper", |
There was a problem hiding this comment.
decided to remove this as this fixed it for me but I'm second guessing whether it was just a me-problem and don't want to impose it on the world
When I tried to update the billing address of Codecov org in prod (update the street name from "St." to "St"), in the UI it made it look like it went through successfully and the PATCH /update-billing-address 200'd.
But then going through the logs showed the error
"Request req_9ak7WzhcpRmZgQ: Your card was declined."And the address is not reflected as changed within Stripe (and therefore not on our UI either).
Fix in this PR so this error can be passed back to gazebo frontend.