Skip to content

Conversation

@codingjoe
Copy link
Owner

  • Add Python 3.13
  • Add Django 3.14
  • Add Django 5.2 (LTS)
  • Add Django 6.0
  • Drop Django 5.1 (EoL)
  • Drop Django 5.0 (EoL)

* Add Python 3.13
* Add Django 3.14
* Add Django 5.2 (LTS)
* Add Django 6.0
* Drop Django 5.1 (EoL)
* Drop Django 5.0 (EoL)
Copilot AI review requested due to automatic review settings December 18, 2025 23:11
@codingjoe codingjoe self-assigned this Dec 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to update the project's packaging configuration and CI infrastructure by modernizing to Python 3.13 and newer Django versions, while removing end-of-life versions. However, the PR introduces several critical issues by referencing non-existent versions of Python (3.14), Django (5.2, 6.0), and GitHub Actions (download-artifact@v7).

Key intended changes:

  • Migrate from setup.py/setup.cfg to modern pyproject.toml-only configuration
  • Replace multiple linting tools (black, flake8, isort, bandit, pydocstyle) with Ruff
  • Modernize CI workflows to use uv instead of pip

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Adds non-existent Python 3.14, Django 5.2, and Django 6.0 classifiers; migrates to dependency-groups with incorrect syntax; consolidates tool configs to Ruff
.github/workflows/ci.yml Updates test matrix with non-existent Python 3.14 and Django versions 5.2/6.0; simplifies workflow using uv
.github/workflows/release.yml Modernizes release workflow using uv and trusted publishing; references non-existent download-artifact@v7
setup.py Removes deprecated setup.py file in favor of pyproject.toml
setup.cfg Removes deprecated setup.cfg file (flake8 config moved to pyproject.toml)
.pre-commit-config.yaml Adds comprehensive pre-commit hooks including ruff, pyupgrade, django-upgrade
README.md Updates code formatting from single to double quotes and adjusts documentation formatting
dynamic_filenames/init.py Modernizes string formatting from %-style to f-string
.gitignore Adds uv.lock to ignored files
tests/testapp/.gitignore Formatting fix
.github/dependabot.yml YAML formatting consistency update
.github/FUNDING.yml Removes funding configuration file
.bandit Removes bandit configuration file (replaced by Ruff)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[project.optional-dependencies]
[dependency-groups]
dev = [
{ include-group = "test" },
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax for including another dependency group appears incorrect. The correct syntax for PEP 735 dependency groups should be just the group name as a string reference, not using a dictionary with 'include-group'. This should be changed to reference the test group properly according to the PEP 735 specification.

Suggested change
{ include-group = "test" },
"test",

Copilot uses AI. Check for mistakes.
@codingjoe codingjoe merged commit ef84d18 into main Dec 18, 2025
14 checks passed
@codingjoe codingjoe deleted the packaging branch December 18, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants