vminitd: correctly support dual-stack network args #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vminitd was not correctly parsing -network args when both an IPv4 and an IPv6 address were provided. Only the latest 'addr' field was kept, overriding the previous one. Fix that by storing the IPv4 and IPv6 addrs separately, and introduce a unit test to verify this works correctly. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
fix-vminitd-nw-args
branch
from
011d46e to
9f99f18
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds dual-stack networking support to vminitd by allowing both IPv4 and IPv6 addresses to be configured simultaneously. The changes refactor the network configuration to handle separate Addr4 and Addr6 fields instead of a single Addr field.
Key changes:
- Modified the
Networkstruct to support separate IPv4 and IPv6 address fields - Updated argument parsing and serialization to handle multiple
addrparameters - Added comprehensive unit tests for the new dual-stack network parsing functionality
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/vminit/vmnetworking/vmnetworking.go | Refactored Network struct to use separate Addr4/Addr6 fields and updated validation/configuration logic |
| internal/shim/task/networking_unix.go | Updated InitArgs() to generate network arguments supporting both IPv4 and IPv6 addresses |
| cmd/vminitd/networking.go | Modified network parsing and serialization to handle dual-stack configuration |
| cmd/vminitd/networking_test.go | Added unit tests covering IPv4-only, IPv6-only, dual-stack, and DHCP scenarios |
| go.mod | Added testify dependency for unit testing |
| Makefile | Added test-unit target for running unit tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robmry
approved these changes
Dec 17, 2025
dmcgowan
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vminitd was not correctly parsing -network args when both an IPv4 and an IPv6 address were provided. Only the latest 'addr' field was kept, overriding the previous one.
Fix that by storing the IPv4 and IPv6 addrs separately, and introduce a unit test to verify this works correctly.