add global options to healthcheck command #4575
Conversation
coderbirju
force-pushed
the
add-namespace-option
branch
from
61bf0a1 to
df9ff8c
Compare
There was a problem hiding this comment.
The pattern used in Compose should be followed:
nerdctl/cmd/nerdctl/compose/compose.go
Line 73 in 804a8cd
There was a problem hiding this comment.
Thanks @AkihiroSuda for the suggestion, I have made chages as requested. We now pass down the options from the CLI during health-check creation.
Most changed files are for passing these new values to the function
PTAL
Can we also add this to v2.2.0
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-namespace-option
branch
from
df9ff8c to
27318a4
Compare
| cmdOpts = append(cmdOpts, "container", "healthcheck", containerID) | ||
|
|
||
| log.G(ctx).Debugf("creating healthcheck timer with: systemd-run %s", strings.Join(cmdOpts, " ")) | ||
| log.G(ctx).Infof("creating healthcheck timer with: systemd-run %s", strings.Join(cmdOpts, " ")) |
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-namespace-option
branch
from
654a56b to
e1b158d
Compare
| // 1. It was explicitly changed via CLI (highest priority), OR | ||
| // 2. It has a non-default value (from TOML config) | ||
| // This ensures both CLI flags and TOML config values are propagated | ||
| if f.Changed || (val != f.DefValue && val != "") { |
There was a problem hiding this comment.
This condition i think should not be there, the function seems to return all global flags, irrespective of changed or not changed. Not sure if this condition is required.
@AkihiroSuda Do you happen to know why we have the condition for compose.
3 participants
Currently the global flags passed to nerdclt is not passed to the healthcheck command, this results in container not found errors while running healthchecks in a namespaced environement
This PR passes the global options to the healthcheck command as well