cgroup-systemd: enable all accounting properties to ensure stats are readable

[sohankunkerkar]

Currently, crun conditionally enables CPUAccounting, MemoryAccounting, and IOAccounting only when corresponding resource limits are set. This breaks Kubernetes conformance tests and metrics collection for containers without resource limits.

This PR enable those properties unconditionally to match runc behavior. This ensures cgroup stats are readable even for containers without resource limits.

Summary by Sourcery

Unconditionally enable CPUAccounting, MemoryAccounting, and IOAccounting in the systemd cgroup driver to ensure container stats are always readable even without resource limits.

Bug Fixes:

• Fix broken metrics collection and Kubernetes conformance failures for containers without resource limits by matching runc behavior.

Enhancements:

• Always enable CPUAccounting, MemoryAccounting, and IOAccounting for systemd cgroup scopes.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update systemd cgroup scope setup to always enable CPU, memory, and IO accounting regardless of resource limits, ensuring metrics are accessible for all containers.

File-Level Changes

Change	Details	Files
Unconditionally enable accounting properties	Removed conditional checks around CPUAccounting, MemoryAccounting, and IOAccounting Added CPUAccounting, MemoryAccounting, and IOAccounting unconditionally Revised comment to reflect always-on accounting behaviour	src/libcrun/cgroup-systemd.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}